This repository has been archived by the owner on Mar 13, 2024. It is now read-only.
Add DNSRecords bindConfig functionality #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terinjokes
reviewed
Sep 4, 2018
terinjokes
suggested changes
Sep 4, 2018
|
This feature is now documented. You can see it at https://api.cloudflare.com/#dns-records-for-a-zone-export-dns-records Also, I made the requested change to the PR |
|
+1 |
|
Is there something about this PR that is preventing it from being merged? I'm still seeing a "Changes requested" message, but that change has already been made and I'm not sure if I'm supposed to clear it somehow? |
|
@mikehardenize It's down to me to re-review. |
|
I've tested this and it works for me. Thanks. |
|
This PR is basically |
|
Merged as c7d48ad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows retrieval of a zone in bind configuration format. Fixes #39